fix: include response limit in build cache key - #298
Open
Utkarshpandey0001 wants to merge 1 commit into
Open
Utkarshpandey0001 wants to merge 1 commit into
Utkarshpandey0001 wants to merge 1 commit into
Conversation
Author
|
@NathanFlurry Hi, Could you please review this PR when you have a chance ? Let me know if you would like me to make any further changes. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxResponseBytesvalue in the build packaging identityTesting
pnpm --filter @rivet-dev/dynamic-apps-core exec vitest run tests/build.test.tspnpm buildpnpm check-typespnpm check-boundariespnpm lintThe regression exercises
buildAppRelease()with a shared artifact cache and verifies a 1536-byte response is rejected by a cached 1024-byte wrapper and accepted by the 2048-byte wrapper. This does not perform a real agentOS build-and-redeploy cycle.Fixes #297