fix: resolve startup crash in saveVaultRepoConfig and remove debug logging - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a startup crash in
saveVaultRepoConfig()that prevented additional repository ignore patterns from being applied, causing files from sub-folders (e.g.shared/) to leak into the primary repository during sync. Also removes temporary debug logging that was added to diagnose the issue.Problem
During early Obsidian startup,
vault.getAbstractFileByPath()returnsnullbecause the vault index hasn't finished loading. The code fell through tovault.create(), which threw "File already exists" because the file was already on disk. This error disrupted the plugin initialization chain beforeinitializeAdditionalRepos()could callconfigure()with the ignore patterns — so sub-folder files were incorrectly synced to the main repo.Changes
main.tssaveVaultRepoConfig(): When the vault index hasn't loaded the file yet, falls back toadapter.exists()/adapter.write()instead of blindly callingvault.create().console.log('[DEBUG]')statements added during investigation.src/services/syncService.tsconsole.log('[DEBUG]')statements fromconfigure(),buildLocalIndex(), andshouldIgnore().Testing
npm run build)