fix: Preserve explicit zero timedelta values in discovery manifests - #230
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Setting retention times to `timedelta(seconds=0)` was silently dropped; instead, the global defaults were used. Now, settings the retention times to 0s properly disables the rentention.
e4b6aa6 to
46016d1
Compare
|
Nice catch, the One thing though: Also would be great to add a small test asserting |
|
The changeset now also covers the |
|
Thank you for the contribution! |
Passing explicit
timedelta(seconds=0)timedelta values for inactivity timeout, abort timeout, journal retention and idempotency retention was silently dropped - instead, the global defaults were used.Now, settings the retention times to
0sproperly disables the rentention.Fixes #172