Creating a way for people to link their discord to their Redbrick accounts - #124
Merged
Conversation
+ Check if uid is taken before registering using the public admin API + Replace the json with the actual one that will be used when creating the new LDAP user + Include their discord id ot the json user-data
+ Check for if the user is already linked + Check if the user is already linked to a different discord account + Actually use the api to add the discord value
+ Changed link_discord_to_ldap to update_user_ldap_attribute for future expansion + Added a send_verification_email function for the link command. + Moved code handling login to its own function
+ Changed /link to /account link + Added a /account pubkey command for users to change their public keys
Arisamiga
marked this pull request as ready for review
August 19, 2026 19:38
liamk024
requested changes
Aug 19, 2026
liamk024
previously approved these changes
Aug 19, 2026
novanai
requested changes
Aug 20, 2026
CG-5228
requested changes
Aug 20, 2026
CG-5228
reviewed
Aug 20, 2026
CG-5228
previously approved these changes
Aug 20, 2026
liamk024
previously approved these changes
Aug 20, 2026
novanai
previously approved these changes
Aug 20, 2026
novanai
left a comment
Contributor
There was a problem hiding this comment.
two nits but not required to change unless you want!
+ Added a extra timer of extra 10 minutes to show the user that their code was expired + Moved the ssh keys to a contact place in config.py
liamk024
approved these changes
Aug 20, 2026
CG-5228
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality for the Admin API, enabling users to link their Discord accounts to Redbrick and modify their account settings, including public keys. Additionally, it allows for the registration of new members by creating Redbrick accounts for them through the Admin API.
closes #43