fix(docs): resolve relative links on nested documentation pages against the page directory - #26
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…st the page directory Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for capacitor-plugin-docs-stripe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the 11
@rdlabo/eslint-plugin-rulesrule pages (rules/*.md), cross-links to sibling rules were broken in both locales:[deny-element](./deny-element.md)→/projects/eslint-plugin-rules/docs/deny-element(404; route isdocs/rules/deny-element)./prefer-modal-launcher.mdwas left as a literal relativehrefbecause local pages never went through link rewritingRoot cause:
rewritePackageDocLinks()rewrote*.mdtargets to/docs/{name}without knowing which directory the current page lives in.Changes in
scripts/package-markdown.ts/scripts/generate-docs.ts:Behaviour is unchanged when
pageFileis omitted or the page is at the docs root, so all existing link tests still pass.../README.mdon nested pages still maps to the landing/API anchors as before.Generated output regenerated with
docs:generate:content; the only diff is 24hrefs ineslint-plugin-rules.{en,ja}.generated.ts.workers-hono-kitJA pages also link to undeclared/docs/api-offline,/docs/api-testing,/docs/clipages — that is a content gap, not a rewrite bug, and is left for a follow-up.Validation (Node 24):
fmt:check,lint,test(155 script tests + Angular suites),build:docs,build:web-site,seo:auditall pass. Baselinedocs:generate:contentonmainproduced zero drift before applying this change.Link to Devin session: https://app.devin.ai/sessions/5c06cafe056340c684ce577fcb2dea10
Open in Devin Desktop: https://app.devin.ai/desktop/session/5c06cafe056340c684ce577fcb2dea10?variant=devin