-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Phase 1 MD3 token migration for all components #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c099224
feat(tokens): introduce Material Design 3 token foundation
rdlabo 4291e80
feat(components): align Button and Toolbar with MD3 tokens
rdlabo fe0e8dd
feat(components): tokenize Card, Chip and FAB
rdlabo b1783cc
feat(components): tokenize Searchbar, Segment, Tabs and Toggle
rdlabo 69f55d2
feat(components): tokenize List and Range
rdlabo 595acb3
feat(components): tokenize overlays (Alert, Action Sheet, Loading, Mo…
rdlabo c32dc34
feat(components): set Content and DateTime surface roles
rdlabo 5a83ef7
fix: respect Ionic `color` prop and restore legacy elevation tokens
rdlabo 91d8809
Merge main
rdlabo 960073f
fix(button): keep iOS shape and use MD3 color/typography
rdlabo 1784885
fix(list): restore iOS list group divider color
rdlabo 8d56597
fix(content): use default Ionic background instead of surface
rdlabo edfcdd0
fix(components): align MD3 token migration with Ionic shape/defaults
rdlabo 2e1d177
chore: update E2E screenshots
github-actions[bot] bfc7cd2
fix(list): inset list divider matches item background
rdlabo 1851e7a
fix(range): restore Ionic slider geometry while keeping MD3 colors
rdlabo d111463
test(rtl): update range geometry assertions for default Ionic shape
rdlabo 21e992a
test(rtl): expect used left/right pixel values for range handle
rdlabo 34bcc3e
chore: update E2E screenshots
github-actions[bot] 4d5c081
feat(action-sheet, alert): add role='preferred' styling and demo exam…
rdlabo d704faf
chore: update E2E screenshots
github-actions[bot] 6b80372
fix(alert): remove focus outline from alert wrapper
rdlabo 664f2ff
chore: update E2E screenshots
github-actions[bot] 5a8426f
fix(action-sheet): set --color on action-sheet buttons for icon tint
rdlabo 0efd136
chore: update E2E screenshots
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.9 KB
(110%)
demo/e2e/screenshot.spec.ts-snapshots/action-sheet-all-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.8 KB
(110%)
demo/e2e/screenshot.spec.ts-snapshots/action-sheet-button-only-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.46 KB
(100%)
demo/e2e/screenshot.spec.ts-snapshots/action-sheet-button-only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.96 KB
(110%)
demo/e2e/screenshot.spec.ts-snapshots/action-sheet-no-cancel-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.48 KB
(100%)
demo/e2e/screenshot.spec.ts-snapshots/action-sheet-no-cancel.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.02 KB
(100%)
demo/e2e/screenshot.spec.ts-snapshots/alert-button-only-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.08 KB
(100%)
demo/e2e/screenshot.spec.ts-snapshots/alert-button-only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.26 KB
(110%)
demo/e2e/screenshot.spec.ts-snapshots/alert-no-cancel-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+991 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/alert-remove-app-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+376 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/breadcrumbs-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Binary file modified
BIN
+412 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/date-and-time-pickers-dark.png
Oops, something went wrong.
Binary file modified
BIN
+232 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/date-and-time-pickers.png
Oops, something went wrong.
Binary file modified
BIN
+249 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/floating-action-button-dark.png
Oops, something went wrong.
Binary file modified
BIN
+236 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/floating-action-button.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+499 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/modal-card-dark.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+499 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/modal-normal-dark.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
demo/e2e/screenshot.spec.ts-snapshots/progress-indicators-icon-only-dark.png
Oops, something went wrong.
Binary file modified
BIN
-120 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/progress-indicators-icon-only.png
Oops, something went wrong.
Binary file modified
BIN
+508 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/progress-indicators-message-dark.png
Oops, something went wrong.
Binary file modified
BIN
+331 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/progress-indicators-message.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+930 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/select-alert-dark.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+562 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/select-modal-dark.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+968 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/select-popover-dark.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+491 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/toast-anchor-dark.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+484 Bytes
(100%)
demo/e2e/screenshot.spec.ts-snapshots/toast-middle-dark.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Ionic の色指定が MD3 の固定色に置き換わる
color属性付きボタンにも primary 背景と文字色が常に適用されます。同じ固定指定を持つ toolbar、card、chip、content、FAB、toggle でも指定色が表示されません。Learn more
Ionic は
color属性から.ion-colorと--ion-color-base/--ion-color-contrastを設定します。今回、文書側のコンポーネント規則が--backgroundと--colorを直接指定するため、その公開 API より MD3 の固定ロールが優先されます。デモにもcolor="success"の button と toggle、color="primary"の toolbar と card など、影響を受ける既存利用があります。Example:
<ion-button color="success" fill="solid">Save</ion-button>は success 色になるべきですが、常に--md-sys-color-primaryと--md-sys-color-on-primaryで描画されます。Recommended fix: 各コンポーネントで
.ion-colorの場合は--ion-color-base/--ion-color-contrastを使う上書きを追加してください。button の outline/clear、toggle の checked 状態、toolbar、card、chip、content、FAB など、固定ロールを設定した全コンポーネントを同じ方針で監査してください。Was this helpful? React with 👍 or 👎 to provide feedback.