Skip to content

feat(frontier): add acknowledge_token_forfeit to DeleteOrganizationRequest - #497

Open
whoAbhishekSah wants to merge 1 commit into
mainfrom
feat/frontier-org-delete-token-forfeit-ack
Open

feat(frontier): add acknowledge_token_forfeit to DeleteOrganizationRequest#497
whoAbhishekSah wants to merge 1 commit into
mainfrom
feat/frontier-org-delete-token-forfeit-ack

Conversation

@whoAbhishekSah

Copy link
Copy Markdown
Member

What

Adds a bool acknowledge_token_forfeit field to DeleteOrganizationRequest.

Why

Part of raystack/frontier#1837. Deleting an organization can forfeit unused prepaid tokens on its billing account. A UI confirmation popup is not enough on its own — the API is public (SDKs, scripts, curl), so the server can only enforce the consent if it arrives inside the request.

Planned behavior in frontier:

  • If the org has unused prepaid tokens and the flag is not set, the delete fails with a failed_precondition error saying how many tokens would be lost.
  • If the flag is set, the delete proceeds and the forfeited amount is written to the audit record.

🤖 Generated with Claude Code

…quest

Deleting an organization can forfeit unused prepaid tokens on its
billing account. The server needs the caller's consent inside the
request to enforce this, so add a bool flag. When the account has
unused tokens and the flag is not set, the delete fails with a
failed_precondition error naming the amount at stake.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedAug 5, 2026, 12:10 PM

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bd9867c-d2f4-4e6b-8750-038b1c4dd4ab

📥 Commits

Reviewing files that changed from the base of the PR and between 0a5d420 and b037da5.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

📝 Walkthrough

Walkthrough

DeleteOrganizationRequest now includes acknowledge_token_forfeit. When unused prepaid tokens exist and the field is false, deletion should fail with failed_precondition and report the amount at stake. When the field is true, deletion may forfeit the unused tokens.

Suggested reviewers: amangit07, rohilsurana

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the addition of the acknowledgment field to DeleteOrganizationRequest.
Description check ✅ Passed The description explains the field, its purpose, and the planned API behavior for token forfeiture.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants