Remove unused nikic/php-parser dependency#37
Conversation
The PhpParser namespace has never been referenced anywhere in src/, src-deprecated/, or the project's git history. The dependency appears to be a leftover from earlier development that no longer applies. Tests, phpstan, and psalm all pass without it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis change removes the unused ChangesDependency Removal
Estimated code review effort: 1 (Trivial) | ~2 minutes Related Issues: None specified Related PRs: None specified Suggested labels: dependencies, documentation Suggested reviewers: None specified 🐰 A parser hopped away, unused and quiet, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@keitamotegi Arigato! |
Summary
nikic/php-parseris required incomposer.json(^v4.13) but thePhpParsernamespace is never referenced anywhere insrc/,src-deprecated/, or the project's entire git history (verified withgit log -S "PhpParser"across all commits).nikic/php-parser: ^5, this unused constraint is currently the only real blocker preventingvimeo/psalm:^6from being installed via a normalcomposer require --devin the main dependency tree (it currently requires a vendor-bin isolation workaround).requirehas no effect on functionality: it may still be pulled in transitively as a dev dependency ofphpunit/php-code-coverage, but it is no longer pinned to^v4.13by this package.Test plan
composer update— resolves cleanly, no conflictscomposer test(phpunit) — 32 tests, 60 assertions, all passcomposer sa(phpstan + psalm) — no errorscomposer cs(phpcs) — passesSummary by CodeRabbit