RDBC-1099 Sync 7.2.3 -> 7.2.6 - #309
Open
poissoncorp wants to merge 29 commits into
Open
poissoncorp wants to merge 29 commits into
poissoncorp wants to merge 29 commits into
Conversation
from_json required an AutoIndexes key and a LockMode, so any payload without them raised. Both C# fields have no initializer: a missing AutoIndexes leaves null, and a missing LockMode lands on Unlock. to_json also iterated the auto-index dict without .items(), so it never serialized one.
This was referenced Sep 11, 2026
Ports RemoteAttachmentExtensions. Backup S3Settings gains the StorageClass it was missing, and the S3 and Azure from_json / to_json paths stop requiring keys that C# treats as optional, since a converted instance carries no backup script.
Operation.wait_for_completion now hands back the result the server carried instead of dropping it, and the smuggler narrows that to a SmugglerResult with per-item-type counts. No existing caller used the return value.
This test pinned wait_for_completion returning None, which is the behaviour the previous commit deliberately changed. It now checks the result the server sent.
AiOutputOptions carries a sample object, an explicit JSON schema, or no schema at all, and run_with_schema / stream_with_schema apply it to a single turn. Nothing is sent when no options are given, so the agent's own schema stays in charge.
VectorSearchToken inherited the base add_alias, which builds a plain WhereToken and so dropped the similarity threshold, candidate count and exactness. It now rebuilds itself with the field qualified. The caller also discarded what add_alias returned, so no alias was ever applied. C# assigns the new token back into the list; this does the same.
Four constructors took a new parameter in the middle of their existing signature, which breaks anyone passing positionally: output_options on RunConversationOperation and its command, store_chunk_text on EmbeddingsGenerationConfiguration, and disable_checksum_validation on RemoteAttachmentsS3Settings. All four move to the end. Operation.wait_for_completion also started returning the server's result instead of None, which is a change every caller can see. It returns None again; the result now comes from _wait_for_completion_result, and the smuggler is its only caller. Also covers the six symbols the coverage audit found untested: import_incremental, export_to_database, get_conversation_messages, CdcSinkTableLoadState, ConnectionStringUsage.list_from_json and UpdateQueueSinkOperationResult.
poissoncorp
force-pushed
the
RDBC-1099-sync-7.2.5
branch
from
September 15, 2026 12:37
66787c1 to
6b8b384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDBC-1112 Sync Python SDK 7.2.5 -> 7.2.6
RDBC-1099 Sync Python SDK 7.2.3 -> 7.2.5
New features
QueueSinkConfiguration,QueueSinkScript,AddQueueSinkOperation,UpdateQueueSinkOperation,OngoingTaskQueueSink,QueueSinkProcessState,AzureServiceBusSinkSource,DatabaseRecord.queue_sinksstore.smuggler:export,import_data,import_incremental,export_to_database,for_database, typedSmugglerResultAddCdcSinkOperation,UpdateCdcSinkOperation,OngoingTaskCdcSink,GetCdcSinkSchemaOperation,TestCdcSinkMappingOperation,DatabaseRecord.cdc_sinksGet/Put/RemoveServerWideConnectionStringOperation,ServerWideConnectionStringGetConversationMessagesOperation,AiOperations.get_conversation_messagesAiOutputOptions,run_with_schema,stream_with_schemaAzureServiceBusConnectionSettings+EntraId/Passwordless,QueueBrokerType.AZURE_SERVICE_BUSAPI changes
ConnectionStringused_by, plusConnectionStringUsage/ConnectionStringUsageKindCertificateMetadatausage,sso_identifiers,sso_server_public_key_pinning_hashes,allow_any_sso_server; newSsoProvider,SsoIdentifier,CertificateUsageEditClientCertificateOperation.ParametersCertificateDefinitionOngoingTaskPullReplicationAsSinkhub_cursor,sink_cursorOngoingTaskTypeCDC_SINKS3Settingsdisable_checksum_validation,storage_class,to_remote_attachments_s3_settings()RemoteAttachmentsS3Settingsdisable_checksum_validation,to_s3_settings()AzureSettings/RemoteAttachmentsAzureSettingsEmbeddingsGenerationConfigurationstore_chunk_textAiConversationcancel_pending_action_toolsDatabaseItemTypeTIME_SERIES_DELETED_RANGES; newDatabaseRecordItemType(39 members)LimitType(59),LicenseLimitException,QueryToolFailedException, all in the dispatcherBreaking changes
Found by AST-comparing every changed signature against
v7.2. All resolved, none ship.output_options(RunConversationOperation+ its command),store_chunk_text(EmbeddingsGenerationConfiguration),disable_checksum_validation(RemoteAttachmentsS3Settings).Operation.wait_for_completion()had started returning the server's result instead ofNone. Reverted; the smuggler reads it through a private_wait_for_completion_result().Deliberate, kept: query aliases now actually apply (different, correct RQL), and several
from_jsonaccept payloads that previously raised.Minors
CLIENT_VERSION7.2.3 -> 7.2.6add_from_alias_to_where_tokensdiscardedadd_alias's result so aliases never applied;VectorSearchTokenlost its settings on aliasing;DatabaseRecord.from_jsonrequiredAutoIndexes+LockMode;DatabaseRecord.to_jsoniterated auto-indexes without.items();AutoIndexDefinition.from_jsonsame strictness; backup settings called.to_json()on a null scriptX-Forwarded-For, 3 newSupportedFeaturesv7.2, same failure set in both directions.