RDoc-4106 Lack of active state in docs subpage select is misleading - #2671
Open
poissoncorp wants to merge 1 commit into
Open
poissoncorp wants to merge 1 commit into
poissoncorp wants to merge 1 commit into
Conversation
The section you are in was removed from the switcher and replaced by a generic "Start" entry, so the list showed every destination except the current one. In Quill that left "Guides" and "Samples" reading as Quill's own. Keep every section on the list and mark the current one active instead. The entry links to the section landing page, so it also covers what "Start" did. Both sidebars now render one shared list from getSectionNavItems(), which drops the per-section conditionals and the hover-only "Switch" labels. Desktop and mobile had drifted apart in the meantime: different order, and mobile still used the sparkles icon for Quill.
poissoncorp
force-pushed
the
RDoc-4106-sidebar-active-state
branch
from
September 15, 2026 12:13
2d36482 to
b3f1fb6
Compare
Lwiel
reviewed
Sep 15, 2026
| external?: boolean; | ||
| } | ||
|
|
||
| const NAV_SECTIONS: readonly { type: PathTypeValue; label: string; icon: IconName; currentOnly?: boolean }[] = [ |
Contributor
There was a problem hiding this comment.
Can we use a concrete type here?
|
|
||
| // Versionless content areas, in match order. The URL segment doubles as the landing page path. | ||
| // Anything that matches none of these is versioned documentation. | ||
| const SECTIONS: readonly { segment: string; type: PathTypeValue }[] = [ |
Contributor
There was a problem hiding this comment.
Here we can also use a concrete type to be consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
RDoc-4106 Lack of active state in docs subpage select is misleading
Additional description
The section you are in was removed from the switcher and replaced by a generic "Start" entry, so the list showed every destination except the current one. In Quill that left "Guides" and "Samples" reading as Quill's own.
Keep every section on the list and mark the current one active instead. The entry links to the section landing page, so it also covers what "Start" did.
Both sidebars now render one shared list from getSectionNavItems(), which drops the per-section conditionals and the hover-only "Switch" labels. Desktop and mobile had drifted apart in the meantime: different order, and mobile still used the sparkles icon for Quill.
Was:
Now:
Type of change
/templatesor readme)Changes in docs URLs
/scripts/redirects.jsonfile, setDocuments MovedPR label)Changes in UX/UI