Skip to content

[pre-commit.ci] pre-commit autoupdate #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pre-commit-ci wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e0781
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Sep 7, 2026
827254b
Merge branch 'main' into pre-commit-ci-update-config
jameslamb Sep 9, 2026
0135b37
zizmor fixes
jameslamb Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-test-publish-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
fail-fast: false
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: ./.github/workflows/build-rapids-image.yml
uses: $/.github/workflows/build-rapids-image.yml

@jameslamb jameslamb Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest zizmor flags these.

help[self-repository]: use GitHub's dedicated self-repository syntax
  --> .github/workflows/publish.yml:30:11
   |
23 |   docker:
   |   ------ this job
...
30 |     uses: ./.github/workflows/build-test-publish-images.yml
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use '$/...' instead of './...'
   |
   = note: audit confidence → High
   = note: this finding has an auto-fix

I like it!

See https://github.blog/changelog/2026-07-30-reference-same-repository-actions-with-self-repository-syntax/

Part of the goal is to avoid source checkouts and unfortunately we still can't do that because we rely on parsing files in source control within these workflows. But still a nice change to adopt.

# Referencing something from the 'matrix' context prevents GitHub auto-generating
# a hard-to-read name with all the matrix input values.
#
Expand Down Expand Up @@ -180,7 +180,7 @@ jobs:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
fail-fast: false
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: ./.github/workflows/build-cuvs-image.yml
uses: $/.github/workflows/build-cuvs-image.yml
# Referencing something from the 'matrix' context prevents GitHub auto-generating
# a hard-to-read name with all the matrix input values.
#
Expand Down Expand Up @@ -279,7 +279,7 @@ jobs:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.TEST_MATRIX) }}
fail-fast: false
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: ./.github/workflows/validate.yml
uses: $/.github/workflows/validate.yml
# Referencing something from the 'matrix' context prevents GitHub auto-generating
# a hard-to-read name with all the matrix input values.
#
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.TEST_MATRIX) }}
fail-fast: false
secrets: inherit # zizmor: ignore[secrets-inherit]
uses: ./.github/workflows/test-notebooks.yml
uses: $/.github/workflows/test-notebooks.yml
# Referencing something from the 'matrix' context prevents GitHub auto-generating
# a hard-to-read name with all the matrix input values.
#
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
id-token: write
packages: read
pull-requests: read
uses: ./.github/workflows/build-test-publish-images.yml
uses: $/.github/workflows/build-test-publish-images.yml
with:
build_type: pull-request
run_tests: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2023-2025, NVIDIA CORPORATION.
# Copyright (c) 2023-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
name: publish

on:
Expand Down Expand Up @@ -27,7 +27,7 @@ jobs:
id-token: write
packages: read
pull-requests: read
uses: ./.github/workflows/build-test-publish-images.yml
uses: $/.github/workflows/build-test-publish-images.yml
with:
build_type: branch
run_tests: ${{ inputs.run_tests || false }}
Expand Down
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2025, NVIDIA CORPORATION.
# Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
---
ci:
autoupdate_schedule: 'monthly'
Expand All @@ -9,17 +9,17 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.16.1
rev: v0.16.6
hooks:
- id: ruff
args: ["--config", "pyproject.toml"]
- repo: https://github.com/shellcheck-py/shellcheck-py
rev: v0.11.0.1
rev: v0.11.0.1-1
hooks:
- id: shellcheck
args: ["--severity=warning", "--external-sources"]
- repo: https://github.com/zizmorcore/zizmor-pre-commit
rev: v1.29.0
rev: v1.30.0
hooks:
- id: zizmor
- repo: https://github.com/rapidsai/pre-commit-hooks
Expand Down
Loading