Conversation
Missing feature version updates are mechanical but easy to overlook, especially after a release reset makes the visible patch number lower than a version already published from the same series. Allow contributors to opt into formatter-style fixes that select the next patch above that same-series high-water mark, update the affected manifests, and stop the commit so the generated changes can be reviewed and staged before retrying. Keep pull-request validation read-only and refuse to overwrite unstaged manifest edits.
Auto-bump must remain a fallback for missing or invalid version changes, not increment a version that a contributor already selected correctly. Exercise the checker with auto-bump enabled and a valid staged version update, and assert that it succeeds without modifying that version again.
msarahan
requested review from
KyleFromNVIDIA
and removed request for
a team
September 9, 2026 19:07
trxcllnt
reviewed
Sep 10, 2026
| "name": "NVIDIA RAPIDS devcontainer build utilities", | ||
| "id": "rapids-build-utils", | ||
| "version": "26.12.0", | ||
| "version": "26.12.1", |
Collaborator
There was a problem hiding this comment.
Does this version need to be bumped in this PR?
Contributor
Author
There was a problem hiding this comment.
I don't understand why it was added. I'll look into why this happened.
Contributor
Author
There was a problem hiding this comment.
This is a catch-up bump from the forward-merge in #768 . It should have been done there. Would you like me to split it off into its own PR, since it is noise in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is common for people to change code in a feature and forget to bump the version. When that happens, the new images are not pushed to GHCR. This check is intended to assist with that.
It accounts for the following possible situations:
This has one config setting - whether to automatically fix files, like a linter.