Patch brace-expansion ReDoS (SNYK-JS-BRACEEXPANSION-17706650)#1033
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cscheid
approved these changes
Jul 1, 2026
cscheid
left a comment
Member
There was a problem hiding this comment.
Yup, all looks good from here, though I haven't recompiled or retested the extension. None of these are "real" in any concrete sense, since ReDOS is about resource exhaustion under adversarial inputs, and if people want to crash their own machines with the extension, there's much simpler ways to go about it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-resolve the transitive brace-expansion dependency to patched versions (1.1.15, 2.1.1, 5.0.7) within each major line, closing the ReDoS advisory across all dependency paths (minimatch via vscode-languageclient, eslint, exceljs, tsup, @vscode/test-cli, and pinyin's optional nodejieba).
This supersedes the Snyk PRs (#1028, #1029, #1030, #1031), each of which proposed a major-version bump of a top-level dependency to shift a single transitive path off the vulnerable package. The lockfile re-resolution fixes every path at once with no VS Code engine bump, no eslint flat-config migration, and no pinyin segmentation change.