Skip to content

Patch brace-expansion ReDoS (SNYK-JS-BRACEEXPANSION-17706650)#1033

Merged
juliasilge merged 1 commit into
mainfrom
fix/brace-expansion-redos
Jul 1, 2026
Merged

Patch brace-expansion ReDoS (SNYK-JS-BRACEEXPANSION-17706650)#1033
juliasilge merged 1 commit into
mainfrom
fix/brace-expansion-redos

Conversation

@juliasilge

Copy link
Copy Markdown
Collaborator

Re-resolve the transitive brace-expansion dependency to patched versions (1.1.15, 2.1.1, 5.0.7) within each major line, closing the ReDoS advisory across all dependency paths (minimatch via vscode-languageclient, eslint, exceljs, tsup, @vscode/test-cli, and pinyin's optional nodejieba).

This supersedes the Snyk PRs (#1028, #1029, #1030, #1031), each of which proposed a major-version bump of a top-level dependency to shift a single transitive path off the vulnerable package. The lockfile re-resolution fixes every path at once with no VS Code engine bump, no eslint flat-config migration, and no pinyin segmentation change.

@posit-snyk-bot

posit-snyk-bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@juliasilge juliasilge requested a review from cscheid July 1, 2026 16:34

@cscheid cscheid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, all looks good from here, though I haven't recompiled or retested the extension. None of these are "real" in any concrete sense, since ReDOS is about resource exhaustion under adversarial inputs, and if people want to crash their own machines with the extension, there's much simpler ways to go about it...

@juliasilge juliasilge merged commit 4ff3e27 into main Jul 1, 2026
4 checks passed
@juliasilge juliasilge deleted the fix/brace-expansion-redos branch July 1, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants