Fix notebook markdown soft line breaks#1027
Merged
juliasilge merged 2 commits intoJun 29, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
|
Thank you so much for this fix, @devmcp! I notice it is still draft, but it looks ready to go to me. Do you have any other changes you want to make before I review? |
Contributor
Author
Nope! I think it's good to review. Many thanks! |
juliasilge
approved these changes
Jun 29, 2026
juliasilge
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this contribution! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown cells in notebooks were rendering soft line breaks as hard paragraph breaks when the Quarto Markdown-It renderer was active. The Pandoc div rule reported every line as a paragraph interrupter during Markdown-It silent validation, so hard-wrapped prose was split before normal Markdown rendering could preserve soft break semantics.
This updates the div parser so silent validation only reports an interruption for actual
:::div markers and does not mutate parser state until the marker is consumed. The new core tests cover both the soft-break regression and the expected paragraph interruption for Pandoc div markers.Fixes #1017
Tests:
npx --yes yarn@1.22.22 workspace core testnpx --yes yarn@1.22.22 workspace quarto-vscode-markdownit buildnpx --yes yarn@1.22.22 build-vscode