gh-133998: Fix tarfile error on out-of-range mtime in streaming gzip mode#151828
Open
harjothkhara wants to merge 1 commit into
Open
gh-133998: Fix tarfile error on out-of-range mtime in streaming gzip mode#151828harjothkhara wants to merge 1 commit into
harjothkhara wants to merge 1 commit into
Conversation
…rites tarfile.open(..., "w|gz", mtime=...) packed mtime into the gzip header's 32-bit field with no range check, so a value < 0 or >= 2**32 raised struct.error. Mirror the merged gzip fix: substitute 0 for out-of-range values and coerce to int (RFC 1952), so floats and out-of-range system clocks behave the same as in gzip and the non-streaming "w:gz" path (which already delegates to GzipFile and was unaffected).
harjothkhara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A streaming gzip tarball (
"w|gz") with an out-of-range mtime (negative, or a clock past 2106) raisesstruct.errorinstead of writing the file.gzip already clamps these to 0 (GH-134278); this does the same for tarfile's streaming path. The non-streaming
w:gzpath usesGzipFile, so it was already fine.Added tests for the boundary and bad-clock cases.
AI-assisted; I reviewed it and can explain it.
2106-02-07T06:28:15#133998