Skip to content

gh-151814: Fix unbounded memory growth from repeated empty writes to io.TextIOWrapper#151817

Open
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:textio-acc
Open

gh-151814: Fix unbounded memory growth from repeated empty writes to io.TextIOWrapper#151817
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:textio-acc

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 20, 2026

Copy link
Copy Markdown
Member

Comment thread Modules/_io/textio.c
else if (!PyList_CheckExact(self->pending_bytes)) {
PyObject *list = PyList_New(2);
if (list == NULL) {
if (bytes_len > 0) {

@StanFromIreland StanFromIreland Jun 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git seems to render the diff poorly, locally I see with -w (--ignore-all-space):

$ git show -w HEAD -- Modules/_io/textio.c
commit c6b5163133619febd0fbe8c327e52399b1a54ffd (HEAD -> textio-acc, origin/textio-acc)
Author: Stan Ulbrych <stan@python.org>
Date:   Sat Jun 20 21:16:54 2026 +0100

    Fix unbounded memory growth from repeated empty writes to io.TextIOWrapper

diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
index 24e08cec88f..5b2a20a30c2 100644
--- a/Modules/_io/textio.c
+++ b/Modules/_io/textio.c
@@ -1820,6 +1820,7 @@ _io_TextIOWrapper_write_impl(textio *self, PyObject *text)
         }
     }
 
+    if (bytes_len > 0) {
         if (self->pending_bytes == NULL) {
             assert(self->pending_bytes_count == 0);
             self->pending_bytes = b;
@@ -1846,6 +1847,11 @@ _io_TextIOWrapper_write_impl(textio *self, PyObject *text)
         }
 
         self->pending_bytes_count += bytes_len;
+    }
+    else {
+        Py_DECREF(b);
+    }
+
     if (self->pending_bytes_count >= self->chunk_size || needflush ||
         text_needflush) {
         if (_textiowrapper_writeflush(self) < 0)

@StanFromIreland StanFromIreland changed the title gh-151814: Fix unbounded memory growth from repeated empty writes to io.TextIOWr… gh-151814: Fix unbounded memory growth from repeated empty writes to io.TextIOWrapper Jun 20, 2026
Comment thread Modules/_io/textio.c
Comment thread Lib/test/test_io/test_textio.py Outdated
@StanFromIreland StanFromIreland requested a review from cmaloney June 21, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants