Fix dot-segment removal for rootless paths - #156
Open
Haasini-kudala wants to merge 1 commit into
Open
Haasini-kudala wants to merge 1 commit into
Haasini-kudala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
Resolving
../bazagainstscheme:foo/barcurrently returnsscheme:baz. This change preserves the slash introduced when/..removes the last output segment, producingscheme:/bazas required by RFC 3986 section 5.2.4.Keep an empty leading segment during dot-segment removal instead of restoring a slash only for paths that originally started with one. Add normalization and resolution regressions for rootless paths, trailing and repeated slashes, excess parent segments, and query/fragment preservation, plus a release note. Sixteen regression cases fail before the fix and pass afterward.
Validation on Python 3.12.14:
pytest --cov rfc3986 --cov-fail-under 100 tests/: 2,937 passed, 100% coverage.pre-commit run --all-files --show-diff-on-failure: all hooks passed.python tests/verify_types.py --quiet: passed (76.87%, above the 75% requirement).python -m build: source distribution and wheel built successfully.