Include is_lazy in import details - #313
Draft
seddonym wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, explicit lazy imports were no different from normal imports. This PR:
is_lazykey to theDetailedImportdict returned byget_import_details.is_lazyargument toadd_import.Still to do
Caching
Figure out how this should work with caching.
Backward compatibility for
add_importTweak the behaviour for
add_importso it's backward-compatible.add_importin the old style, both with and without the old optional arguments (line_number/line_contents). If called with the optional arguments,is_lazyshould beFalse.is_lazy. It probably makes sense in that case also to requireline_number/line_contents. Might be worth taking the opportunity to raise a better exception if this isn't followed.