Unified examples - #348
Draft
gubaidulinvadim wants to merge 2 commits into
Draft
Conversation
for each large use case. Only the configuration file now needs to be swapped to run the same example. This will help to avoid having some examples that work and some that do not because of recent changes in the code. Old examples will be deleted if we agree on these unified examples.
gubaidulinvadim
requested review from
JeanLucPons,
TeresiaOlsson,
kparasch and
simoneliuzzo
August 14, 2026 12:48
Member
|
Thanks for this unification ! |
gubaidulinvadim
marked this pull request as draft
August 14, 2026 13:08
Member
Author
|
I converted to draft because I will need to remove some config files and old examples before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified examples for ESRF, BESSY II and SOLEIL II in thematic notebooks for each large use case.
Only the configuration file now needs to be swapped to run the same example. This will help to avoid having some examples that work and some that do not because of recent changes in the code. And we will only need to modify a single example valid for all facilities instead of many slightly different ones. Old examples will be deleted if we agree on these unified examples.
Resolves #182
Resolves #170 as the path is now different (and the problem was maybe already nonexistent)
Resolves #171 as the new examples were checked to be running without errors