feat: re-export Settings from pytest_django for typing (#1257) - #1280
Merged
Conversation
SAY-5
force-pushed
the
export-settings-wrapper
branch
from
May 21, 2026 06:55
52df77a to
b0ca5ec
Compare
bluetech
force-pushed
the
export-settings-wrapper
branch
from
August 3, 2026 14:29
b0ca5ec to
367d72b
Compare
bluetech
approved these changes
Aug 3, 2026
bluetech
left a comment
Member
There was a problem hiding this comment.
Thanks!
I updated the PR according to my comments in the issue: #1257 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1257.
SettingsWrapperis now importable from the top-levelpytest_djangonamespace so thesettingsfixture can be type-annotated without reaching intopytest_django.fixtures:Mirrors the existing pattern used for
DjangoAssertNumQueriesandDjangoCaptureOnCommitCallbacks.SettingsWrappertopytest_django.__all__settingsfixture indocs/helpers.rstTestSettings