fix and enable fp32 multigrid-v2 collo kernels - #855
Open
Efithor wants to merge 3 commits into
Open
Conversation
Collaborator
|
We don't plan to enable fp32 by default, as its numerical behavior is not guaranteed. You can add a cmake option to enable fp32 for users who want to experiment it in local build. |
Contributor
Author
@sunqm Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for LDA/GGA FP32 instantiations of multigrid-v2 collocation kernels the per-grid-point pair for float the corner value underflows while the recursion start factors overflow, giving 0 * inf = NaN. Fixed via evaluating exponent directly instead of recursion product + these codepaths . Double routes and MGGA drivers are unaffected