Conversation
pyTooling gains a 'cli' extra installing what the 'pyTooling' program needs at runtime: colorama, because the program is a TerminalApplication, and matplotlib, because '--gantt' draws with it. A consumer writing 'pyTooling[cli]' in its requirements gets no MSYS2 rewrite today, so the MinGW64 and UCRT64 jobs would try to build matplotlib from source and fail. 'cli' rewrites to 'python-matplotlib:p' alone: it installs the dependencies of 'diagram' and 'terminal', and only the first of those has compiled code - which is the same reason 'terminal' needs no entry of its own. 'tests/pacman_packages.py' is left alone. It holds an older, partial copy of both dictionaries - no 'diagram', no 'pypi', no 'sphinx' under 'pytooling' - no workflow runs it, and bringing it into sync is a separate job. Co-Authored-By: Patrick Lehmann <Paebbels@gmail.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (4b1ca13) 45 41 91.11% Head commit (49cde03) 45 (+0) 41 (+0) 91.11% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#268) 1 1 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
ComputePacboyPackagesknows pyTooling'scliextra.subPackages["pytooling"]gained"cli": "python-matplotlib:p", so a consumer writingpyTooling[cli]in a requirements file gets the MSYS2package instead of an attempt to build matplotlib from source in MinGW64 and UCRT64.
The extra is new in pyTooling v10.0 and holds what the
pyToolingprogram needs at runtime: colorama,because the program is a
TerminalApplication, and matplotlib, because its--ganttoption draws with it.Only matplotlib is rewritten.
cliinstalls the dependencies ofdiagramandterminal, and only the firstof those has compiled code — colorama is pure Python and installs from PyPI on MSYS2 unaided, which is why
terminalhas no entry of its own either.Checked by running the action's own dictionaries and regular expression against a set of dependency lines, so
the check reads
action.ymlrather than a copy of it:pyTooling[cli] >= 10.0python-matplotlib:ppyTooling[cli,yaml] >= 10.0python-matplotlib:p,python-ruamel-yaml:p python-ruamel.yaml.clib:ppyTooling[terminal] ~= 10.0matplotlib >= 3.10python-matplotlib:pChanges
@r8needs no adjustment beyond the version branch moving.
Known Issues
tests/pacman_packages.pyholds an older, partial copy of the two dictionaries inComputePacboyPackages/action.yml— underpytoolingit has onlyyaml, and it is missingdiagram,pypiand
sphinx. No workflow runs it, so it drifts unnoticed. Bringing it into sync, or replacing it with a checkthat reads
action.yml, is tracked for a later release.Related Issues and Pull-Requests
cliextra.application tests that found the gap.