Skip to content

DOC: fix broken links (NREL, EnergyPlus, git-scm, Wikipedia ΔT) #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgowdaan-cmyk wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −7
Open

DOC: fix broken links (NREL, EnergyPlus, git-scm, Wikipedia ΔT) #2818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e31585
DOC: fix broken links (NREL, EnergyPlus, git-scm, Wikipedia ΔT)
dgowdaan-cmyk Jul 9, 2026
7c81d6a
Add whatsnew entry for broken links fix
dgowdaan-cmyk Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sphinx/source/user_guide/getting_started/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ Follow these steps to obtain the library using git/GitHub:
Please see GitHub's
`Forking Projects <https://guides.github.com/activities/forking/>`_,
`Fork A Repo <https://help.github.com/articles/fork-a-repo/>`_,
and the `git-scm <https://git-scm.com/documentation>`_ for
and the `git-scm <https://git-scm.com/doc>`_ for
Comment thread
dgowdaan-cmyk marked this conversation as resolved.
more details.

.. _setupenvironment:
Expand Down
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.15.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Documentation
* Fix broken link in GitHub Contributing tab. (:issue:`2628`, :pull:`2806`)
* Fixed broken ``interval`` keyword argument in the ``oedi_9068`` gallery
example; the correct parameter name is ``time_step``. (:issue:`2791`)
* Fixed several broken/outdated links: NREL clear-sky and spectral data
pages, EnergyPlus documentation, git-scm.com, and a malformed Wikipedia
URL. (:issue:`2489`)


Testing
Expand Down
4 changes: 2 additions & 2 deletions pvlib/iotools/epw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def read_epw(filename, coerce_year=None):
----------

.. [1] `EnergyPlus documentation, Auxiliary Programs
<https://energyplus.net/documentation>`_
<https://energyplus.readthedocs.io/en/latest/>`_
'''

if str(filename).startswith('http'):
Expand Down Expand Up @@ -259,7 +259,7 @@ def _parse_epw(csvdata, coerce_year=None):
A pandas dataframe with the columns described in the table
below. For more detailed descriptions of each component, please
consult the EnergyPlus Auxiliary Programs documentation
available at: https://energyplus.net/documentation.
available at: https://energyplus.readthedocs.io/en/latest/.

metadata : dict
The site metadata available in the file.
Expand Down
2 changes: 1 addition & 1 deletion pvlib/solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def spa_c(time, latitude, longitude, pressure=101325., altitude=0.,
redefined by Python>=3.5. This issue is
`Python bug 24643 <https://bugs.python.org/issue24643>`_.

.. [2] Delta T: https://en.wikipedia.org/wiki/%CE%94T_(timekeeping)
.. [2] Delta T: https://en.wikipedia.org/wiki/%CE%94T_(timekeeping%29

.. [3] USNO delta T: https://maia.usno.navy.mil/products/deltaT

Expand Down
6 changes: 3 additions & 3 deletions pvlib/spectrum/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def get_reference_spectra(wavelengths=None, standard="ASTM G173-03"):
For global spectra, it is about 1000.37 W/m².

The values of the ASTM G173-03 provided with pvlib-python are copied from
an Excel file distributed by NLR, which is found here [2]_:
https://www.nlr.gov/grid/solar-resource/assets/data/astmg173.xls
an Excel file distributed by NREL, which is found here [2]_:
https://www.nrel.gov/grid/solar-resource/spectra-am1.5
Comment on lines +50 to +51

@cwhanse cwhanse Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
an Excel file distributed by NREL, which is found here [2]_:
https://www.nrel.gov/grid/solar-resource/spectra-am1.5
an Excel file distributed by NLR, which is found here [2]_:
https://www.nlr.gov/grid/solar-resource/spectra-am1.5

Any NREL domain changed to NLR last month. Attribution is to NLR, unless the reference is to a document and we're describing the publisher at the time of publication.


Examples
--------
Expand Down Expand Up @@ -79,7 +79,7 @@ def get_reference_spectra(wavelengths=None, standard="ASTM G173-03"):
.. [1] ASTM "G173-03 Standard Tables for Reference Solar Spectral
Irradiances: Direct Normal and Hemispherical on 37° Tilted Surface."
.. [2] “Reference Air Mass 1.5 Spectra.” NLR.
https://www.nlr.gov/grid/solar-resource/spectra-am1.5.html
https://www.nrel.gov/grid/solar-resource/spectra-am1.5

@cwhanse cwhanse Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

""" # Contributed by Echedey Luis, inspired by Anton Driesse (get_am15g)
SPECTRA_FILES = {
"ASTM G173-03": "ASTMG173.csv",
Expand Down
Loading