Conversation
Opt in independently with incremental_index_pages=true. Reuse unchanged page content and memberships, and rebuild derived state after failed versions or gaps. Generated-by: Codex
Contributor
Author
|
Suggested review order:
The binary-index integration is separate in #498. Neither PR requires the other, and HTML pages remain normal content served by the existing handler. Review human approval is still needed for this AI-generated implementation. |
Generated-by: Codex
gerrod3
force-pushed
the
cx/incremental-maven-index-pages
branch
from
September 18, 2026 17:02
18dcc24 to
88f4860
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small Maven repository modification currently queries descendant content to regenerate ancestor HTML pages. This adds an independent
incremental_index_pages=truerepository label: maintain each directory's immediate children, render dirty pages, and reuse unchanged page artifacts and memberships.Extracted from #498 and based directly on
main. It has no dependency on the experimental binary-index integration or S3 index storage. It retains ordinaryMavenIndexPagecontent and the existing content-serving behavior.Review the two commits in order: generator/schema, then lifecycle coverage and documentation. A review-order comment identifies the key correctness checks.
Validation: full unit suite 181 passed, 3 optional S3 tests skipped, 4 subtests passed; eight directory lifecycle tests cover a public modify task with 200 orphan uploads, retention, no-ops, failed versions, repair, opt-in gaps, and base-version switching. Ruff, public pulpcore import checks, and migration consistency pass. A combined checkout with #498 also passed all 24 lifecycle tests with both opt-ins enabled. Production-size throughput is not established by these tests.
AI disclosure: code, tests, documentation and this description were generated with Codex. Commits carry
Generated-by: Codex; human review is pending.