Skip to content

Proposal: Overhaul PulpUI Github Actions to a hardened, per job-concern model. #362

Description

@Redtigercod4

Summary

The current Continuous Integration (CI) implementation against main runs a set of checks against every pull request, but lacks the newer security posture needed in areas such as static analysis, dependency review and pipeline documentation. As development on pulp-ui accelerates and new features sets land, the pipeline needs to grow to match both to cover new security requirements and provide clear, consistent gateway for code to pass through.

This proposes a full restructure, not an incremental patch, to a job-per-concern reusable-workflow model. Every addition will be mapped explicitly to either OWASP or an existing internal Pulp governance.

High Level Design

Image

Implementations

Continuous checks - pr.yml / main.yml / schedule.yml

  • linting: Handles all linting using application tooling via eslint, prettier and tsc.
  • workflow-lint: Lints the CI workflows and raises issues.
  • tests: Existing test command, unchanged.
  • build: Existing build command, unchanged.
  • sast-quality: Conducts static analysis across the application code using codeql.
  • secrets-scaning: Uses gitleaks as per Pulp governance.
  • dependency-review: Checks newly added packages against current.
  • sca: Conducts full scan of dependency tree.

Release-gated checks - release.yml

  • build: Existing build command, unchanged.build: Existing build command, unchanged.
  • provenance: Generates SBOM then using ephemeral keys, attests against the build.

Out of Scope

  1. Logging and Visibility - requires administrative permissions to conduct an audit on current logging and retention on GitHub actions within this repository to suggest a course of action (COA).

  2. Changes to branching strategy - future branching iterations for feature release will be out of scope.

References

  1. https://docs.github.com/en/actions/reference/security/secure-use
  2. https://owasp.github.io/www-project-top-10-ci-cd-security-risks/
  3. https://github.com/Redtigercod4/pulp-ui/tree/next/.github/workflows

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions