Skip to content

Fix agent client generation - #203

Open
decko wants to merge 4 commits into
pulp:mainfrom
decko:pulp-2219-agent-client-generation
Open

decko wants to merge 4 commits into
pulp:mainfrom
decko:pulp-2219-agent-client-generation

Conversation

@decko

@decko decko commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

This PR builds on #202, which now provides isolated per-agent generator copies. It adds the remaining client-generation and agent-startup fixes:

  • use the current gen-client.sh interface
  • forward API-version and wait for API readiness
  • preserve transactional agent creation with traversable 755 permissions
  • generate pulpcore bindings before plugin bindings when needed

Generator compatibility

The previous implementation invoked pulp-openapi-generator/generate.sh, which performed project normalization (pulpcore -> core, pulp_rpm -> rpm) before invoking gen-client.sh.

The checked-out generate.sh explicitly prints DEPRECATED: use ./gen-client.sh instead. This PR invokes gen-client.sh directly. The project-to-component normalization remains in the oci-env adapter because gen-client.sh accepts a component name, not a Pulp project name. Older generator checkouts without gen-client.sh now fail with an actionable update message.

Validation

  • fresh agent created and started with the pulp-2367 pulpcore worktree
  • API status returned 200
  • pulpcore client generation and import succeeded
  • python3 -m compileall -q client/oci_env
  • bash -n base/local_scripts/generate_client.sh
  • git diff --check
  • RPM functional smoke test: 4 passed, 1 skipped

Assisted-by: OpenAI GPT-5.6

@decko decko changed the title PULP-2219: Fix agent client generation Fix agent client generation Sep 11, 2026
Assisted-by: OpenAI GPT-5.6
Assisted-by: OpenAI GPT-5.6
@decko
decko force-pushed the pulp-2219-agent-client-generation branch from afb3557 to c31eaec Compare September 14, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant