Skip to content

Document proxy_set_shared_data(key, NULL) (remove). - #100

Merged
PiotrSikora merged 4 commits into
proxy-wasm:mainfrom
PiotrSikora:kvstore_remove
Aug 11, 2026
Merged

Document proxy_set_shared_data(key, NULL) (remove).#100
PiotrSikora merged 4 commits into
proxy-wasm:mainfrom
PiotrSikora:kvstore_remove

Conversation

@PiotrSikora

Copy link
Copy Markdown
Member

No description provided.

@mpwarres

Copy link
Copy Markdown
Contributor

IIUC from discussion here, we are leaning towards not adding this, and sticking to a more minimal API where removal is expressed by passing a value of null.

Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
@PiotrSikora PiotrSikora changed the title Add proxy_remove_shared_key. Document proxy_set_shared_data(key, NULL) (remove). Mar 19, 2026
@PiotrSikora

Copy link
Copy Markdown
Member Author

IIUC from discussion here, we are leaning towards not adding this, and sticking to a more minimal API where removal is expressed by passing a value of null.

Correct. Documented this behavior in the updated version of this PR.

@PiotrSikora PiotrSikora linked an issue May 21, 2026 that may be closed by this pull request
@PiotrSikora PiotrSikora linked an issue May 21, 2026 that may be closed by this pull request

@leonm1 leonm1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merging

@PiotrSikora
PiotrSikora merged commit 52e0260 into proxy-wasm:main Aug 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent style in the ABI (expanded vs minimal) Add the host function for removing shared data

3 participants