Skip to content

chore: Make deploy-projectsveltos's image-loading step overridable #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Jul 29, 2026
Merged

chore: Make deploy-projectsveltos's image-loading step overridable #1897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,19 @@ deploy-crds: $(KUBECTL) ## Install libsveltos CRDs
$(KUBECTL) apply -f https://raw.githubusercontent.com/projectsveltos/libsveltos/$(TAG)/manifests/apiextensions.k8s.io_v1_customresourcedefinition_reloaderreports.lib.projectsveltos.io.yaml


# Overridable so callers who already built, loaded, and patched the manifests for their own
# image can skip load-image's rebuild - which would otherwise call docker-build's own
# set-manifest-image and overwrite whatever image patch those callers already set - by
# passing LOAD_IMAGE_TARGET=noop.
LOAD_IMAGE_TARGET ?= load-image

.PHONY: noop
noop: ## Does nothing; see LOAD_IMAGE_TARGET above.

deploy-projectsveltos: $(KUSTOMIZE) $(ENVSUBST) $(KUBECTL)
# Load projectsveltos image into cluster
@echo 'Load projectsveltos image into cluster'
$(MAKE) load-image
$(MAKE) $(LOAD_IMAGE_TARGET)

$(MAKE) deploy-crds

Expand Down
Loading