Conversation
renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.
image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.
The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.
describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.
The helper had one caller and existed only to wrap a two-line stream open.
It has no production caller.
The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.
connect and disconnect repeated the same client, ids and network checks.
deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.
deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.
Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.
renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).ReadSpecURIreads a spec from a URL or a file for bothimage buildand the workload commands.DeployOptionsonce; the cpumem params of deploy and realloc come from one helper.slices;GetNetworkssplits withstrings.Cut(a value carrying a second=keeps its pinned meaning);describeChOrdecides the format once;listChanis inlined;ToChanlives with the tests that use it.Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands,
image buildpasses core's code through),--outputexceptions,--versionfields, global option placement,pod capacityrequired flags, the lambda command-line rule and defaults, the--extra-resourcesexample and note, the short flag aliases the tables omitted, the unset template variable rendering<no value>, and the README output claim.Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and
--helpdefaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.