Fix: Add property w JSDoc block after property #8154#8936
Open
vamshi567bh wants to merge 4 commits into
Open
Conversation
Author
|
@ksen0 please check when you have time thanks! |
Member
|
Hi @vamshi567bh welcome! In the future please wait to be assigned before making the PR (this is part of the contributor guidelines, please review those as well) Please update issue description with a screenshot verifying the fix worked. This is the guide for testing locally Thanks! |
Author
|
@ksen0 thansk for the replie i have upadted discription with locally tests passed thanks! |
Member
|
@vamshi567bh I meant screenshot of the website running locally and having the valid entry for |
Author
|
@ksen0 really sorry for misunderstanding please check now thanks! |
Author
|
@davepagurek @ksen0 please review thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #8154
Changes
Add
@property wJSDoc block forp5.Vectoralongside the existingx,y,zproperty blocks. Thewcomponent was already implemented as a getter/setter but was missing from the documentation definition, so it never appeared in the generated reference docs.PR Checklist
npm run docsgenerates correct data withwas a p5.Vector memberscreenshot