Retire the last inherited allowances: the append owners, the validated-postings fixtures, the linux footprint read and the absorber's accepted flags; remove the final 23 warnings - #140
Merged
Conversation
…d-postings fixtures, the linux footprint read and the absorber's accepted flags The append owners' remaining line, argument, nesting, lock-poison, bool-parameter and digest contracts are narrow expectations, as are the validated-postings fixtures' arithmetic, casts and indexing. The absorber's config fields stay for the CLI flags that feed them and say so on the struct, and the test-only Absorber::start lives beside the owner so it ends below its merge-base size. The linux-only collapsible_if on the statm read is a cfg-gated expectation, since a body edit in that sampler would select a mutant no test observes. Both ledgers are empty of inherited occurrences. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…arnings-remainder
Batch 7 moved the fleet tests out, so the linux collapsible_if gate on rss_bytes that this branch adds now grows an oversized file past its merge-base size. Merging the header imports and dropping blank lines between items brings the file back under the base without touching any function body. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
CI's mutation baseline twice timed out r24, once asserting local acceptance the instant the WAL PUT engaged and once waiting for the seal fence. The first is SlateDB's 5 ms flush tick landing between the group's WAL append and its publication; the bounded acceptance wait already covers it and r03 now waits the same way instead of asserting. The second is the retry close forming a group of its own when the committer wakes between the two submissions: a retry on a closed stream writes nothing, and a no-write group joins the prior barrier through the dispatch gate the test is holding, so the fence is never staged. The commit gate now parks the committer until both requests are queued, so they always share the second group. The mechanism pin follows r24's new body. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last chunk of the inherited-warning cleanup: the 23 occurrences left after batch 7 (the append owners, the validated-postings fixtures, the absorber's accepted-but-unread configuration and the linux-only footprint read).
Stated as expectations (owner; invariant; why the simpler alternative is wrong)
application/append*: the line, argument, nesting, lock-poison, bool-parameter and digest contracts ofexecute_prepared,execute_once,admit_usage,prepare_close,closed_tail_failure,complete,parse_content,product_request_hash,RequestWork::runandTicket::wait.postings/validated/tests.rs: the reference clipper reproduces the pre-owner arithmetic on purpose; the fixtures' casts and indexes restate their own sizes.history.rs:AbsorberConfig'sbatch_puts,pass_bytes,small_pass_bytesandconcurrencyare fed by CLI flags that existing deployments pass, so they stay and the struct says so;Absorber's store and key cache likewise. Removing them would editbootstrap::run's body, whose blank-body mutant no test can observe.fleet.rs: the linux-onlycollapsible_ifon the statm read is a cfg-gated expectation for the same reason; its linux-ledger entry is retired by hand since the macOS gate cannot see it.Moved beside its owner: the test-only
Absorber::start(history/test_support.rs, effect owner re-registered), which returns history.rs below its merge-base size after the two struct expectations.Both diagnostic ledgers are empty of inherited occurrences after this chunk.
src/postings/validated/tests.rsjoins the registered mutation owners; no executable body changes are in the diff.🤖 Generated with Claude Code