Move the HTTP, shard and billing test support beside their owners; state the three largest owners' remaining contracts; remove 72 inherited warnings - #137
Closed
sorenbs wants to merge 9 commits into
Conversation
…ing contracts; flatten the delete cascade The tombstone repair and the billing closes leave delete_lifecycle as their own functions, the retained-name refusal joins the winner decision, identical seal-claim arms are combined, and the dead-letter refusal is one match on the append outcome. Everything that stays as it is carries its contract as a narrow expectation. Both ledgers are pruned of the 59 occurrences this removes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…hain walk and the batch overflow verdict The fork-chain walk breaks with let-else, the runtime constructor consumes its entropy, the cursor widths convert with try_from, the hot-key merge keeps the minimum with min, the failpoint registry has a named type, and every stale or bare allowance is gone or reasoned. The remaining line, argument, nesting, lock-poison, cast and effect contracts are narrow expectations; the shutdown driver, the touch flusher and main are registered effect owners. Both ledgers are pruned of the occurrences this removes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…g contracts; combine the unknown-outcome arms The trace store consumes its operation inputs, the fault store's FNV prime is grouped at byte boundaries, latencies sort with total_cmp, the compactor options are one literal, and the bare allowances carry their reasons. The remaining fixture, argument, nesting and cast contracts are narrow expectations; the deliberate stream leak is a registered effect owner. Both ledgers are pruned of the occurrences this removes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…s' into codex/warnings-batch-7 # Conflicts: # docs/quality/diagnostic-allowances.json
…nto codex/warnings-batch-7 # Conflicts: # docs/quality/diagnostic-allowances.json # docs/quality/source-allowances.json # scripts/quality/mutations.sh
… codex/warnings-batch-7 # Conflicts: # docs/quality/diagnostic-allowances.json # docs/quality/owners.json # docs/quality/source-allowances.json
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…duplicate the committer's rejection; state the three largest owners' remaining contracts The HTTP fixture adapters and unit tests, the shard engine's test codec helpers and dirty-scan fault injection, and the injectable billing clock live beside their owners under their old names. The committer's fenced-queue rejection is the transaction's reject_op, the producer-row and consumer-fence types have names, the stale argument allowance on raise_nofile is gone, and the entry points are crate-visible. The remaining line, argument, nesting, cast, lock-poison, builder and spawn contracts are narrow expectations, one attribute per function; the per-connection JoinSet task and the debug abort are registered effect owners. All three files end at or below their merge-base size and both ledgers are pruned of the 72 occurrences this removes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Renaming the call sites edited the bodies of scan_dirty_streams and scan_dirty_streams_page, whose blank-body mutants no shard test observes; the helper is imported instead and the call sites stay. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk of the inherited-warning cleanup: the HTTP surface, the shard engine and the billing owner (72 occurrences), the three largest files in the crate.
Moved beside their owners (test-only): the HTTP fixture adapters and unit tests (
http/test_support.rs,http/tests.rs), the shard engine's test codec helpers and dirty-scan fault injection (shard/test_support.rs), and the injectable billing clock (billing/test_clock.rs). Every relocated global is re-registered under its new path; the old paths stay reachable throughpub(crate) usere-exports, so no scenario call changes.Fixed rather than annotated
shard.rs: the committer's fenced-queue rejection (two identical matches) istransaction::CommitTransaction::reject_op; the producer-row and consumer-fence types have names;CommitOp,durable_absorbed,count_consumer_state_rows,submit_billing_closeanddurable_consumer_fenceare crate-visible.http.rs: the stale argument allowance that had drifted ontoraise_nofileis gone, the raw-querysigallowance carries its reason,routeris crate-visible, andsse_response's allowance is an expectation.Stated as expectations (owner; invariant; why the simpler alternative is wrong): the line, argument, nesting, cast, lock-poison, builder and spawn contracts of the remaining functions;
serve_h1's per-connection JoinSet task and the debug abort are registered effect owners. Functions with several lints carry one attribute naming all of them.All three files end at or below their merge-base size.
src/http.rsjoinssrc/shard.rsas a registered mutation owner; executable changes are confined to the committer dedup and the visibility edits.🤖 Generated with Claude Code