fix: include the local Postgres runtime in published CLI packages - #270
Closed
AmanVarshney01 wants to merge 2 commits into
Closed
AmanVarshney01 wants to merge 2 commits into
AmanVarshney01 wants to merge 2 commits into
Conversation
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
commit: |
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Member
Author
|
Closing in favor of the project-owned runtime fix in prisma/create-prisma#102 and the resolver/error-message fix in prisma/composer#296. The consolidated CLI design treats @prisma/dev as an optional project dependency; adding it to every CLI installation is not needed. Fresh Bun and pnpm scaffolds have been verified with the published CLI, without this packaging change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hold: not required for the project-owned dependency fix
Do not merge this as a prerequisite for fixing create-prisma local development.
This PR adds
@prisma/devto both published CLI packages. It was opened on the assumption that Prisma 8 was expected to supply the runtime transitively. Reviewing the history showed that the consolidated CLI never declared it, and the CLI design explicitly identifies it as an optional, project-owned dependency.The active fix is:
@prisma/devdevDependency.Both fresh Bun and pnpm projects have been verified with the scaffolding fix and the published Prisma CLI, without this PR. Leave this draft open only for an explicit maintainer decision to change dependency ownership; it is not part of the proposed merge set.
What this alternative changes
@prisma/dev@0.25.2as a production dependency of bothprismaand@prisma/cli.Previous technical verification
The proposed packaging works technically: build, typecheck, lint, and all five release-subject conformance checks passed; CLI tests were 964 passed / 2 skipped. Packed CLI and Composer packages started a freshly generated Bun monorepo locally, applied its migration, and served seeded users across a restart. These checks do not establish that changing CLI dependency ownership is the intended design.