Skip to content

fix: include the local Postgres runtime in published CLI packages - #270

Closed
AmanVarshney01 wants to merge 2 commits into
mainfrom
codex/include-local-postgres-runtime
Closed

AmanVarshney01 wants to merge 2 commits into
mainfrom
codex/include-local-postgres-runtime

Conversation

@AmanVarshney01

@AmanVarshney01 AmanVarshney01 commented Sep 15, 2026

Copy link
Copy Markdown
Member

On hold: not required for the project-owned dependency fix

Do not merge this as a prerequisite for fixing create-prisma local development.

This PR adds @prisma/dev to both published CLI packages. It was opened on the assumption that Prisma 8 was expected to supply the runtime transitively. Reviewing the history showed that the consolidated CLI never declared it, and the CLI design explicitly identifies it as an optional, project-owned dependency.

The active fix is:

Both fresh Bun and pnpm projects have been verified with the scaffolding fix and the published Prisma CLI, without this PR. Leave this draft open only for an explicit maintainer decision to change dependency ownership; it is not part of the proposed merge set.

What this alternative changes

  • Adds @prisma/dev@0.25.2 as a production dependency of both prisma and @prisma/cli.
  • Keeps the runtime external and lazily loaded by Composer rather than imported at startup or bundled into CLI JavaScript.
  • Updates the existing packaging conformance allowlists and manifest parity assertion.

Previous technical verification

The proposed packaging works technically: build, typecheck, lint, and all five release-subject conformance checks passed; CLI tests were 964 passed / 2 skipped. Packed CLI and Composer packages started a freshly generated Bun monorepo locally, applied its migration, and served seeded users across a restart. These checks do not establish that changing CLI dependency ownership is the intended design.

Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@270
npx https://pkg.pr.new/@prisma/cli-engine@270

commit: 43456bc

Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
@AmanVarshney01

Copy link
Copy Markdown
Member Author

Closing in favor of the project-owned runtime fix in prisma/create-prisma#102 and the resolver/error-message fix in prisma/composer#296. The consolidated CLI design treats @prisma/dev as an optional project dependency; adding it to every CLI installation is not needed. Fresh Bun and pnpm scaffolds have been verified with the published CLI, without this packaging change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant