add flow-over-heated-plate/fluid-openfoam-basicReactingMultiphaseClou…#834
Conversation
…d tutorial case to show verification of implicit coupling of Lagrangian particles
|
corresponds with precice/openfoam-adatper pull request here: |
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: |
|
Thanks for contributing the tutorial as well! I have not yet looked closer, but the problem setup is different than the current flow-over-heated-plate tutorial, right? In that case, the convention would be to make a separate tutorial directory (e.g., |
The problem setup is the exact same as the flow-over-heated-plate tutorial with the exception that the necessary files / settings are such that 100 Lagrangian parcels / particles (1 particle per parcel) are injected at time = 0 and are left to propagate through the domain. The intent was to give the particles the same properties as the fluid so that they simply follow the flow rather than affect it, thus making any changes in the solution potential flags for something being wrong with the Lagrangian particle implicit coupling implementation. I debated whether to slide this contribution under the flow-over-heated-plate tutorial, or make it a stand alone tutorial. I'm happy to do either. Do you want to wait to decide what should be done until you take a closer look, or are you pretty decided that it should be a separate tutorial and I should go ahead and make the change? |
|
I will take a closer look to this tutorial, the adapter PR, and the related discussion in ~a week. For comparison, we have: as separate tutorials. |
…o" instead of explicit lib for patch injection
…eCloud as its own tutorial flow-over-heated-plate-particles
which are created when openfoam collated file format is used
I reformatted this contribution as its own tutorial rather than being a subset of the flow-over-heated-plate tutorial. Anything else you see that's needed before we can take this off draft status? |
|
@mike-tree-corvid with a quick look, it seems like the structure is fine and I have everything I need to do a review. I am in a different context than OpenFOAM these days, but I will eventually do a detailed review together with the changes in the adapter. Regarding the CI failure: if you could reduce a bit the size of the GIF file (e.g., lower frequency), it would be great, otherwise I will see how we can better handle that. The |
| /*--------------------------------*- C++ -*----------------------------------*\ | ||
| | ========= | | | ||
| | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox | | ||
| | \\ / O peration | Version: 5 | | ||
| | \\ / A nd | Web: www.OpenFOAM.org | | ||
| | \\/ M anipulation | | | ||
| \*---------------------------------------------------------------------------*/ |
There was a problem hiding this comment.
Note that we typically don't have these headers and comment separateor lines in our configuration files, unless they are really from OpenFOAM (and the version is important).
add flow-over-heated-plate/fluid-openfoam-basicReactingMultiphaseCloud tutorial case to show verification of implicit coupling of Lagrangian particles
TODO: Summarize and motivate the changes, link to issues, remove the checklist entries that are not relevant.
Checklist
changelog-entries/<PRnumber>.md.For new tutorials or tutorial cases:
README.mdmetadata.yamltools/tests/tests.yaml_config.yaml