fix(python): avoid masking health check errors - #1912
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
The Python sidecar health check caught every
Exception, which hid unexpected programming errors and made all failures indistinguishable from an unavailable server.Why this change was made
The handler now catches only expected I/O and malformed-response failures, records them at debug level, and lets unexpected exceptions propagate.
User impact
Normal connection and malformed-health-response failures still report an unhealthy server, while unrelated defects retain their original traceback for diagnosis.
Evidence
python -m pytest tests/test_server_manager.py -q— 4 passedpython -m mypy --follow-imports=skip --ignore-missing-imports sdks/python/pmxt/server_manager.py— passedpython -m black --check sdks/python/tests/test_server_manager.py— passedFixes #1790