Skip to content

Add total alkalinity response to benthic-pelagic exchange of nutrients - #183

Merged
yutiPML merged 4 commits into
masterfrom
182-losing-total-alkalinity-in-ersem
Aug 18, 2026
Merged

Add total alkalinity response to benthic-pelagic exchange of nutrients#183
yutiPML merged 4 commits into
masterfrom
182-losing-total-alkalinity-in-ersem

Conversation

@hpowley

@hpowley hpowley commented Aug 11, 2026

Copy link
Copy Markdown
Member

Description of Work

Fixed error in total alkalinity by adding total alkalinity response to benthic-pelagic exchange of nutrients in benthic_column_dissolved_matter.F90

Testing Instructions

  1. Double check changes made to file
  2. Check changes made to fabm.yaml have correct charge sign
  3. Check changes have been applied to all fabm.yaml files (including ERSEM15.06 and Blackford)

@hpowley
hpowley requested review from glessin and yutiPML August 11, 2026 15:27
@hpowley hpowley linked an issue Aug 11, 2026 that may be closed by this pull request
yutiPML
yutiPML previously approved these changes Aug 11, 2026

@yutiPML yutiPML left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments to the yaml files to explain the meaning of the new parameters, and added a "." to ensure values are read as floating point

@wathen
wathen force-pushed the 182-losing-total-alkalinity-in-ersem branch from 82a6275 to 3f61187 Compare August 18, 2026 13:05

@yutiPML yutiPML left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to code have the desired effect.
new reference outputs are needed because the change in the code lead to different set of output due to changes in benthic-pelagic fluxes of TA

@yutiPML
yutiPML merged commit 6ae048e into master Aug 18, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Losing total alkalinity in ERSEM

3 participants