Skip to content

fix/pdf group and group technician#73

Open
Herafia wants to merge 4 commits into
mainfrom
fix/groups-array-technician-group-and-group
Open

fix/pdf group and group technician#73
Herafia wants to merge 4 commits into
mainfrom
fix/groups-array-technician-group-and-group

Conversation

@Herafia

@Herafia Herafia commented Jul 15, 2026

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !45124
  • When generating a PDF, the group and the technician group were identical.
    groups_id and groups_id_tech are now arrays (AssignableItem type), rather than integers. A helper function, getGroupDisplayName(), has been added to handle both formats for compatibility.

Screenshots (if appropriate):

image image

@Herafia Herafia self-assigned this Jul 15, 2026
@Herafia Herafia added the bug Something isn't working label Jul 15, 2026
@Herafia
Herafia requested review from Rom1-B and stonebuzz July 16, 2026 12:50
Comment thread inc/appliance.class.php

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both calls pass true for $strip_tags (which already runs Toolbox::stripTags() internally) and then wrap the result in Toolbox::stripTags() again. It's harmless (stripping twice is a no-op) but redundant ; every other call site strips tags exactly once. Drop the true argument on both lines, or drop the outer Toolbox::stripTags().

Comment thread inc/common.class.php

@stonebuzz stonebuzz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Herafia

Herafia commented Jul 17, 2026

Copy link
Copy Markdown
Author

Ah, yes ! ='D @stonebuzz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants