Fix: use CFG_GLPI root_doc for dropdownAuthorization AJAX path#142
Open
RHmais-IM wants to merge 1 commit into
Open
Fix: use CFG_GLPI root_doc for dropdownAuthorization AJAX path#142RHmais-IM wants to merge 1 commit into
RHmais-IM wants to merge 1 commit into
Conversation
Fixes hardcoded absolute path that breaks on subdirectory installs of GLPI. See issue pluginsGLPI#141
Contributor
|
can you adapt CHANGELOG.md ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #141.
The AJAX call to
dropdownAuthorization.phpused a hardcoded absolute path(
/plugins/oauthimap/...), which breaks on installations where GLPI is notat the domain root. This change uses
CFG_GLPI['root_doc']instead, consistentwith how paths are handled elsewhere in GLPI core.
Tested on GLPI 11.0.8, installation in a subdirectory (
/glpi/public).