Skip to content

Do not hold the global BleedingEdgeToggle across yield in data providers - fixes racy/flaky tests #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 18 commits into from
Jun 22, 2026
+840 −818
Merged

Do not hold the global BleedingEdgeToggle across yield in data providers - fixes racy/flaky tests #5911

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
87d4e4b
Do not hold the global `BleedingEdgeToggle` across `yield` in `Consta…
staabm Jun 21, 2026
62fd8c7
Extract `PHPStanBleedingEdgeToggleTestCase` for `BleedingEdgeToggle` …
phpstan-bot Jun 21, 2026
f05f566
Adopt `PHPStanBleedingEdgeToggleTestCase` in remaining `BleedingEdgeT…
phpstan-bot Jun 21, 2026
d747651
Add BleedingEdgeToggle::withBleedingEdge() set/restore helper
phpstan-bot Jun 21, 2026
41e1160
Use BleedingEdgeToggle::withBleedingEdge() in tests instead of base t…
phpstan-bot Jun 21, 2026
c446259
cleanup
staabm Jun 21, 2026
66c8d7a
Update BleedingEdgeToggle.php
staabm Jun 21, 2026
56ceb9b
Build legacy array shapes under explicit toggle in ConstantArrayTypeT…
phpstan-bot Jun 21, 2026
d71c56c
Return one big array instead of yielding in ConstantArrayType data pr…
phpstan-bot Jun 22, 2026
63d1d5f
Add BleedingEdgeToggle::withBleedingEdge tests including generator guard
phpstan-bot Jun 22, 2026
d345593
Split ConstantArrayTypeTest providers into with/without bleeding edge
phpstan-bot Jun 22, 2026
a85e5ed
Delete tests/PHPStan/DependencyInjection/BleedingEdgeToggleTest.php
staabm Jun 22, 2026
9879299
Create BleedingEdgeToggleTest.php
staabm Jun 22, 2026
d382826
Update ConstantArrayTypeBuilderTest.php
staabm Jun 22, 2026
1c8642a
Keep dataGetArraySize trailing cases under bleeding edge toggle
phpstan-bot Jun 22, 2026
466b2b6
Re-add foreach loop in dataGetArraySize to minimize diff
phpstan-bot Jun 22, 2026
5af91c0
Shorten BleedingEdgeToggle data-provider comments
phpstan-bot Jun 22, 2026
5de1f40
Build container before entering bleeding-edge window in testIsSuperTy…
phpstan-bot Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading