PFA: Fix strict_types checking when a const arg is inlined - #23256
Draft
arnaud-lb wants to merge 1 commit into
Draft
PFA: Fix strict_types checking when a const arg is inlined#23256arnaud-lb wants to merge 1 commit into
arnaud-lb wants to merge 1 commit into
Conversation
Girgias
reviewed
Aug 13, 2026
Comment on lines
+581
to
+583
| zend_argument_type_error_ex(function, offset + 1, | ||
| "must be of type %s, %s given", | ||
| ZSTR_VAL(need_msg), zend_zval_value_name(&argv[offset])); |
Member
There was a problem hiding this comment.
Is this being thrown "at compile time"? As I imagine this could be unexpected.
Member
Author
There was a problem hiding this comment.
Not exactly at compile time. This code executes when a PFA expression is evaluated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-22829 added an optimization to burn literal arguments into the generated closure. An overlooked side effect is that this arguments are not checked anymore by
zp_bind()(GH-22789).Fix by checking these arguments ahead of time.
Bug found by Ryan @ Calif.io.