Skip to content

Zend: Normalize empty string to NULL in OnUpdateStrNotEmpty #23085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arshidkv12 wants to merge 3 commits into from
+27 −2
Closed

Zend: Normalize empty string to NULL in OnUpdateStrNotEmpty #23085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e048fb
Zend: Normalize empty string to NULL in OnUpdateStrNotEmpty
arshidkv12 Aug 6, 2026
e4e03fb
Zend: Normalize empty string to NULL in OnUpdateStrNotEmpty
arshidkv12 Aug 6, 2026
2424b2c
Zend: Normalize empty string to NULL in OnUpdateStrNotEmpty
arshidkv12 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ext/standard/tests/serialize/gh23082.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
--TEST--
Bug GH-23082: Restoring unserialize_callback_func to an empty string
--INI--
display_errors=1
--FILE--
<?php

function my_callback($name)
{
echo "callback fired for $name\n";
}

$prev = ini_set('unserialize_callback_func', 'my_callback');
var_dump($prev);

var_dump(ini_set('unserialize_callback_func', $prev));
var_dump(ini_get('unserialize_callback_func'));

unserialize('O:20:"SomeNotExistingClass":0:{}');

?>
--EXPECT--
string(0) ""
string(11) "my_callback"
string(0) ""
2 changes: 1 addition & 1 deletion ext/standard/var_unserializer.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,7 @@ object ":" uiv ":" ["] {
}

/* Check for unserialize callback */
if (PG(unserialize_callback_func) == NULL) {
if (PG(unserialize_callback_func) == NULL || ZSTR_LEN(PG(unserialize_callback_func)) == 0) {
incomplete_class = 1;
ce = PHP_IC_ENTRY;
break;
Expand Down
2 changes: 1 addition & 1 deletion main/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ PHP_INI_BEGIN()
STD_PHP_INI_BOOLEAN("auto_globals_jit", "1", PHP_INI_PERDIR|PHP_INI_SYSTEM, OnUpdateBool, auto_globals_jit, php_core_globals, core_globals)
STD_PHP_INI_BOOLEAN("short_open_tag", DEFAULT_SHORT_OPEN_TAG, PHP_INI_SYSTEM|PHP_INI_PERDIR, OnUpdateBool, short_tags, zend_compiler_globals, compiler_globals)

STD_PHP_INI_ENTRY("unserialize_callback_func", NULL, PHP_INI_ALL, OnUpdateStrNotEmpty, unserialize_callback_func, php_core_globals, core_globals)
STD_PHP_INI_ENTRY("unserialize_callback_func", NULL, PHP_INI_ALL, OnUpdateStr, unserialize_callback_func, php_core_globals, core_globals)
STD_PHP_INI_ENTRY("serialize_precision", "-1", PHP_INI_ALL, OnSetSerializePrecision, serialize_precision, php_core_globals, core_globals)
STD_PHP_INI_ENTRY("arg_separator.output", "&", PHP_INI_ALL, OnUpdateStrNotEmpty, arg_separator.output, php_core_globals, core_globals)
STD_PHP_INI_ENTRY("arg_separator.input", "&", PHP_INI_SYSTEM|PHP_INI_PERDIR, OnUpdateStrNotEmpty, arg_separator.input, php_core_globals, core_globals)
Expand Down
Loading