ext/intl: Include <limits> for std::numeric_limits - #23072
Merged
Conversation
Member
|
a little |
devnexen
reviewed
Aug 5, 2026
devnexen
left a comment
devnexen
left a comment
Member
There was a problem hiding this comment.
lgtm otherwise, needs to fix broken builds.
Member
Author
|
I am used to add the tag when squash&merging. |
Member
Author
|
Does this worth a NEWS entry? @devnexen |
Member
|
I do not think so |
Co-authored-by: David Carlier <devnexen@gmail.com>
LamentXU123
force-pushed
the
intl-benchmark
branch
from
August 5, 2026 16:32
1d4ec14 to
c32774b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix #21101 (comment)
The bug is quite hidden. This line of code in the commit
Some extreme build environments happen to get std::numeric_limits through transitive includes. So we need to put a Include manually