Fix GH-22915: Preserve parent regs in zend_jit_deoptimizer_start() - #22916
Open
arnaud-lb wants to merge 4 commits into
Open
Fix GH-22915: Preserve parent regs in zend_jit_deoptimizer_start()#22916arnaud-lb wants to merge 4 commits into
arnaud-lb wants to merge 4 commits into
Conversation
iliaal
reviewed
Aug 4, 2026
iliaal
reviewed
Aug 4, 2026
iliaal
approved these changes
Aug 4, 2026
iliaal
left a comment
iliaal
left a comment
Contributor
There was a problem hiding this comment.
Looks good, 2 small nits/notes up-to you if you want to address them, non-blockers imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See GH-22915.
Fix by emitting an early RLOAD for every register that will be saved later.
This was already done at the beginning of side traces, but not in "compiled exits" aka blacklisted side traces.
Should fix https://github.com/php/php-src/actions/runs/30059575887/job/89378471139#step:15:2441.
This changes
opcache.jit_max_side_tracesto aPHP_INI_ALL. Should be harmless and makes the test reliable.