Skip to content

Feat/register phpinfo entries - #2578

Open
henderkes wants to merge 6 commits into
mainfrom
feat/register_phpinfo_entries
Open

Feat/register phpinfo entries#2578
henderkes wants to merge 6 commits into
mainfrom
feat/register_phpinfo_entries

Conversation

@henderkes

@henderkes henderkes commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

closes #2576

image

Edit: the entries are sorted now.

@dunglas I know you've worked on the watcher-go library before, perhaps you could expose a proper version number instead?

@henderkes

Copy link
Copy Markdown
Contributor Author

@dunglas I think we should revert the last commit and make not passing the nobrotli tag a build error when libbrotli isn't available. It would shift the runtime error to a compile time error.

@dunglas

dunglas commented Jul 29, 2026

Copy link
Copy Markdown
Member

For watcher, this is because of e-dant/watcher#102

Comment thread frankenphp.go Outdated
Comment thread frankenphp.go Outdated
Comment thread mercure.go
"github.com/dunglas/mercure"
)

func init() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many other modules can influence what FrankenPHP does. I wonder if we should just list all installed modules, with their versions. It's verbose, but it covers all use cases and is practical to debug.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about it, but I can't really see a use-case for it. It would just clutter away the information we can really influence.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FrankenPHP extensions, Prometheus-related modules. Actually, even the exact go version matters (HTTP stdlib behavior sometimes change). Maybe could we hide this by default in a <details> HTML element?

@henderkes
henderkes force-pushed the feat/register_phpinfo_entries branch 2 times, most recently from 33a4a54 to f1f8ca5 Compare August 4, 2026 16:25
@henderkes
henderkes force-pushed the feat/register_phpinfo_entries branch from f1f8ca5 to f06d146 Compare August 4, 2026 16:29
@henderkes

Copy link
Copy Markdown
Contributor Author

@dunglas I'm not sure if we really should rename AddPhpinfoEntry to AddPHPInfoEntry. Phpinfo refers to the phpinfo() function to print this.

@dunglas

dunglas commented Aug 4, 2026

Copy link
Copy Markdown
Member

I'm not sure either but this sounds more idiomatic to me. People who will call this function will do it in Go, it in PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Caddy version to the FP version in phpinfo() results

2 participants