Feat/register phpinfo entries - #2578
Conversation
|
@dunglas I think we should revert the last commit and make not passing the |
|
For watcher, this is because of e-dant/watcher#102 |
| "github.com/dunglas/mercure" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Many other modules can influence what FrankenPHP does. I wonder if we should just list all installed modules, with their versions. It's verbose, but it covers all use cases and is practical to debug.
There was a problem hiding this comment.
I've thought about it, but I can't really see a use-case for it. It would just clutter away the information we can really influence.
There was a problem hiding this comment.
FrankenPHP extensions, Prometheus-related modules. Actually, even the exact go version matters (HTTP stdlib behavior sometimes change). Maybe could we hide this by default in a <details> HTML element?
33a4a54 to
f1f8ca5
Compare
f1f8ca5 to
f06d146
Compare
|
@dunglas I'm not sure if we really should rename |
|
I'm not sure either but this sounds more idiomatic to me. People who will call this function will do it in Go, it in PHP. |
closes #2576
Edit: the entries are sorted now.
@dunglas I know you've worked on the watcher-go library before, perhaps you could expose a proper version number instead?