Remove filename conventions for do-not-translate in revcheck#319
Open
alfsb wants to merge 1 commit into
Open
Conversation
|
|
||
| // Only in translations | ||
|
|
||
| if ( $filename == "translation.xml" ) |
Member
There was a problem hiding this comment.
What is this file? Why is it ignored here?
| if ( $filename == "translation.xml" ) | ||
| return true; | ||
|
|
||
| // At least, do not ignore |
Member
There was a problem hiding this comment.
I really hate code comments. If you could remove the comments from this function while you are at it, it would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final part of removing filename conventions for do-not-translate files in revcheck lib.
No big changes here, but this may make third_party_ext_documentation a little less surprising, and easier to debug. Depends on doc-en 5662. Plan to merge it by next friday, if output of revchecks of all languages show no differences.
Comments and reviews wellcome.