[BUGFIX] Sync dashboard state with query parameters - #218
Open
niharikag09 wants to merge 2 commits into
Open
Conversation
Update variable and viewed-panel state when client-side navigation changes URL query parameters without remounting providers. Preserve runtime variable metadata and avoid URL feedback loops while restoring defaults when parameters are removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4cf3b16-36e7-4e36-b731-560fe823d1f8 Signed-off-by: Niharika Jha <niharikajha@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Client-side navigation can update dashboard query parameters without remounting the dashboard and variable providers. The URL then points to the new trace/panel while the persistent Zustand stores continue using stale values until a reload.
This change:
var-*query parameters into existing variable state while preserving options and loading metadataviewPanelRefchanges without remounting or losing store-originated panel selectionsTests
npm run type-check --workspace=@perses-dev/dashboardsFixes perses/perses#4330