[FEATURE] Add disable_auto_refresh config - #212
Conversation
…a server config (default false) Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>
2e9c4cb to
e7d4d0f
Compare
|
@mixturesolutions mind checking the tests and lint failures? |
| const [paramsLoaded, setParamsLoaded] = useState<boolean>(false); | ||
|
|
||
| const { refresh } = query; | ||
| const effectiveInitialRefreshInterval = disableAutoRefresh ? DISABLED_REFRESH_INTERVAL : initialRefreshInterval; |
There was a problem hiding this comment.
Not sure if we need all this logic to set the refresh interval to a default one. It complicates the logic when the admin re enables it as is persistent in the URL and there is no path to reset it to the default value that might come from the dashboard. If the refresh action is already gated we might not need to edit the query params.
There was a problem hiding this comment.
Not sure if we need all this logic to set the refresh interval to a default one. It complicates the logic when the admin re enables it as is persistent in the URL and there is no path to reset it to the default value that might come from the dashboard. If the refresh action is already gated we might not need to edit the query params.
You are absolutely right, I simplified this and a lot more, only keeping the necessary changes. Everything should work now.
Co-authored-by: Gabriel Bernal <gabrielbernalp@gmail.com> Signed-off-by: Iris Ye <143642859+mixturesolutions@users.noreply.github.com>
Signed-off-by: Iris Ye <iris.ye.cs@gmail.com>
Description
Adds an optional admin config flag to centrally disable dashboard auto-refresh, addressing perses/perses#4295
Default: false (no behavior change unless explicitly enabled)
When enabled:
Note this is linked with another PR in the main perses repo
Screenshots
To enable, change in the respective perses config yaml file like the following:

Once the changes are deployed, config page will reflect the changes and the dashboard ui will look like:

Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: