Skip to content

fix(SearchIcon): Replace SearchIcon with RhMicronsSearchIcon#12525

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-search-icon-with-rh-microns-search
Open

fix(SearchIcon): Replace SearchIcon with RhMicronsSearchIcon#12525
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-search-icon-with-rh-microns-search

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 24, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated the search icon used throughout the library for empty states, search inputs, search toggles, toolbars, and related demos/examples to consistently use RhMicronsSearchIcon.
  • Documentation
    • Refreshed icon references in component and demo docs to match the new search icon across examples.
  • Tests
    • Adjusted icon-related assertions to reflect the updated search icon rendering in the affected components.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e81de133-0d86-40f8-b770-f25c1fe3c181

📥 Commits

Reviewing files that changed from the base of the PR and between 25bbc0f and f51849a.

⛔ Files ignored due to path filters (4)
  • packages/react-core/src/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/components/TreeView/__tests__/__snapshots__/TreeViewSearch.test.tsx.snap is excluded by !**/*.snap
  • packages/react-core/src/deprecated/components/DualListSelector/__tests__/__snapshots__/DualListSelector.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (61)
  • packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyState.md
  • packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawer.md
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawerGroups.tsx
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawerLightweight.tsx
  • packages/react-core/src/components/SearchInput/SearchInput.tsx
  • packages/react-core/src/components/TextInputGroup/__tests__/TextInputGroupMain.test.tsx
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroup.md
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupFilters.tsx
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupUtilitiesAndIcon.tsx
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupWithStatus.tsx
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/TreeView/TreeViewSearch.tsx
  • packages/react-core/src/demos/AlertGroup.md
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/CustomMenus/ContextSelector.md
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/CustomMenus/OptionsMenu.md
  • packages/react-core/src/demos/CustomMenus/examples/ContextSelectorDemo.tsx
  • packages/react-core/src/demos/Filters/FilterDemos.md
  • packages/react-core/src/demos/Filters/examples/FilterAttributeSearch.tsx
  • packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
  • packages/react-core/src/demos/Filters/examples/FilterMixedSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSameSelectGroup.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSearchInput.tsx
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/TextInputGroupDemo.md
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-core/src/demos/examples/AlertGroup/AlertGroupToastWithNotificationDrawer.tsx
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/examples/TextInputGroup/AttributeValueFiltering.tsx
  • packages/react-core/src/demos/examples/TextInputGroup/AutoCompleteSearch.tsx
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposableTree.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorTreeDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/InputGroupDemo/InputGroupDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/NotificationDrawerDemo/NotificationDrawerGroupsDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/NotificationDrawerDemo/NotificationDrawerLightweightDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-table/src/components/Table/examples/Table.md
  • packages/react-table/src/components/Table/examples/TableEmptyState.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableEmptyStateDefault.tsx
  • packages/react-table/src/demos/examples/TableFilterable.tsx
  • packages/react-table/src/deprecated/components/Table/examples/LegacyTableEmptyState.tsx
  • packages/react-table/src/deprecated/components/Table/examples/Table.md
✅ Files skipped from review due to trivial changes (46)
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-core/src/demos/examples/AlertGroup/AlertGroupToastWithNotificationDrawer.tsx
  • packages/react-table/src/deprecated/components/Table/examples/LegacyTableEmptyState.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyState.md
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawer.md
  • packages/react-core/src/demos/CustomMenus/OptionsMenu.md
  • packages/react-core/src/components/DualListSelector/examples/DualListSelector.md
  • packages/react-table/src/components/Table/examples/Table.md
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroup.md
  • packages/react-core/src/demos/CustomMenus/ContextSelector.md
  • packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx
  • packages/react-core/src/demos/CustomMenus/examples/ContextSelectorDemo.tsx
  • packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
  • packages/react-core/src/components/TreeView/TreeViewSearch.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
  • packages/react-table/src/demos/examples/TableFilterable.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSearchInput.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/InputGroupDemo/InputGroupDemo.tsx
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawerLightweight.tsx
  • packages/react-core/src/components/NotificationDrawer/examples/NotificationDrawerGroups.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorTree.tsx
  • packages/react-core/src/demos/TextInputGroupDemo.md
  • packages/react-core/src/demos/PrimaryDetail.md
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupUtilitiesAndIcon.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorComplexOptionsActions.tsx
  • packages/react-table/src/demos/examples/TableEmptyStateDefault.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposableTree.tsx
  • packages/react-core/src/demos/Filters/examples/FilterSameSelectGroup.tsx
  • packages/react-core/src/demos/examples/TextInputGroup/AutoCompleteSearch.tsx
  • packages/react-core/src/demos/AlertGroup.md
  • packages/react-integration/demo-app-ts/src/components/demos/NotificationDrawerDemo/NotificationDrawerLightweightDemo.tsx
  • packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx
  • packages/react-core/src/demos/Filters/FilterDemos.md
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelectorComposable.tsx
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/demos/Filters/examples/FilterMixedSelectGroup.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailContentPadding.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailInlineModifier.tsx
  • packages/react-core/src/demos/Filters/examples/FilterAttributeSearch.tsx
  • packages/react-table/src/deprecated/components/Table/examples/Table.md
  • packages/react-table/src/components/Table/examples/TableEmptyState.tsx
  • packages/react-core/src/demos/Filters/examples/FilterFaceted.tsx
  • packages/react-core/src/deprecated/components/DualListSelector/examples/DualListSelector.md
🚧 Files skipped from review as they are similar to previous changes (15)
  • packages/react-core/src/components/TextInputGroup/tests/TextInputGroupMain.test.tsx
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx
  • packages/react-core/src/demos/Compass/Compass.md
  • packages/react-core/src/demos/examples/TextInputGroup/AttributeValueFiltering.tsx
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupWithStatus.tsx
  • packages/react-core/src/components/EmptyState/examples/EmptyStateNoMatchFound.tsx
  • packages/react-core/src/demos/examples/PrimaryDetail/PrimaryDetailFullPage.tsx
  • packages/react-core/src/components/DualListSelector/examples/DualListSelectorBasicSearch.tsx
  • packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx
  • packages/react-core/src/components/SearchInput/SearchInput.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/NotificationDrawerDemo/NotificationDrawerGroupsDemo.tsx
  • packages/react-core/src/components/TextInputGroup/examples/TextInputGroupFilters.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorWithActionsDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/DualListSelectorTreeDemo.tsx
  • packages/react-table/src/demos/Table.md

Walkthrough

Replaces SearchIcon with RhMicronsSearchIcon across component implementations, examples, demos, integration demos, and table examples.

Changes

SearchIcon → RhMicronsSearchIcon replacement

Layer / File(s) Summary
Core component implementations
packages/react-core/src/components/SearchInput/SearchInput.tsx, packages/react-core/src/components/TreeView/TreeViewSearch.tsx, packages/react-core/src/components/TextInputGroup/__tests__/TextInputGroupMain.test.tsx, packages/react-core/src/components/TextInputGroup/examples/TextInputGroup*.tsx, packages/react-core/src/components/TextInputGroup/examples/TextInputGroup.md
SearchInput, TreeViewSearch, and all TextInputGroup examples and tests swap SearchIcon for RhMicronsSearchIcon in imports, rendered JSX, and test assertions.
react-core component examples and docs
packages/react-core/src/components/DualListSelector/examples/*, packages/react-core/src/components/EmptyState/examples/*, packages/react-core/src/components/NotificationDrawer/examples/*, packages/react-core/src/components/Toolbar/examples/Toolbar.md
EmptyState icon props and search button icon props in DualListSelector, EmptyState, NotificationDrawer, and Toolbar examples are updated to RhMicronsSearchIcon; corresponding markdown import lists are updated.
react-core demo examples and docs
packages/react-core/src/demos/AlertGroup.md, packages/react-core/src/demos/Compass/..., packages/react-core/src/demos/CustomMenus/..., packages/react-core/src/demos/Filters/examples/*, packages/react-core/src/demos/NotificationDrawer/..., packages/react-core/src/demos/PrimaryDetail.md, packages/react-core/src/demos/examples/...
All demo files across AlertGroup, Compass, CustomMenus, Filters, Nav, NotificationDrawer, PrimaryDetail, TextInputGroup, and Toolbar replace SearchIcon with RhMicronsSearchIcon in both icon imports and icon prop usages.
Deprecated components and integration test demos
packages/react-core/src/deprecated/components/DualListSelector/examples/*, packages/react-integration/demo-app-ts/src/components/demos/DualListSelectorDemo/*, packages/react-integration/demo-app-ts/src/components/demos/InputGroupDemo/InputGroupDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/NotificationDrawerDemo/*, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
Deprecated DualListSelector examples and all integration test demo components replace SearchIcon imports and EmptyState/button icon props with RhMicronsSearchIcon.
react-table examples, demos, and deprecated table
packages/react-table/src/components/Table/examples/Table.md, packages/react-table/src/components/Table/examples/TableEmptyState.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableEmptyState*.tsx, packages/react-table/src/demos/examples/TableFilterable.tsx, packages/react-table/src/deprecated/components/Table/examples/*
Table package examples, demos, and the legacy table empty state replace SearchIcon with RhMicronsSearchIcon in imports and EmptyState icon props.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

Needs design review

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: replacing SearchIcon with RhMicronsSearchIcon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-search-icon-with-rh-microns-search branch from 7b9039c to 25bbc0f Compare June 24, 2026 01:49
@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 24, 2026 02:11
@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:17
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-search-icon-with-rh-microns-search branch from 25bbc0f to f51849a Compare June 24, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants