Skip to content

fix(QuestionIcon): Replace QuestionIcon with RhUiQuestionMarkIcon#12509

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-question-icon-with-rh-ui-question-mark
Open

fix(QuestionIcon): Replace QuestionIcon with RhUiQuestionMarkIcon#12509
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-question-icon-with-rh-ui-question-mark

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Documentation
    • Updated HelperText component examples to showcase an alternative icon option.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1965d7ae-57a4-4cde-8251-2b55fe7e6c6b

📥 Commits

Reviewing files that changed from the base of the PR and between aa4f9fd and 70b11bb.

📒 Files selected for processing (2)
  • packages/react-core/src/components/HelperText/examples/HelperText.md
  • packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx

Walkthrough

In the HelperText examples, the icon used for the indeterminate state is changed from QuestionIcon to RhUiQuestionMarkIcon. The import and the icon prop in HelperTextWithCustomIcon.tsx are updated, along with the corresponding import line in HelperText.md.

Changes

HelperText icon replacement

Layer / File(s) Summary
Icon import and usage update
packages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsx, packages/react-core/src/components/HelperText/examples/HelperText.md
Replaces QuestionIcon with RhUiQuestionMarkIcon in the import and icon prop of the indeterminate HelperTextItem, and updates the matching import in the markdown documentation snippet.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing QuestionIcon with RhUiQuestionMarkIcon, which matches the file modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, however this particular RH icon to me is rather difficult to see due to how thin it is.

@rebeccaalpert rebeccaalpert requested a review from kmcfaul June 24, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants