Skip to content

fix(WarningTriangleIcon): Replace WarningTriangleIcon with RhUiWarningIcon#12508

Open
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-warning-triangle-icon-with-rh-ui-warning
Open

fix(WarningTriangleIcon): Replace WarningTriangleIcon with RhUiWarningIcon#12508
rebeccaalpert wants to merge 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-warning-triangle-icon-with-rh-ui-warning

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 23, 2026

Copy link
Copy Markdown
Member

What:
Part of #12402. Breaking into separate PRs so it is easier to review.

Additional issues:

Summary by CodeRabbit

  • Style
    • Updated warning icon styling across Modal components and documentation for improved visual consistency.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rebeccaalpert, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 39 minutes and 28 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d9ef597-a600-46aa-bedd-683534e90363

📥 Commits

Reviewing files that changed from the base of the PR and between 4191abf and f892ec3.

📒 Files selected for processing (6)
  • packages/react-core/src/components/Modal/examples/Modal.md
  • packages/react-core/src/components/Modal/examples/ModalCustomHeader.tsx
  • packages/react-core/src/deprecated/components/Modal/examples/Modal.md
  • packages/react-core/src/deprecated/components/Modal/examples/ModalCustomHeaderFooter.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ModalDemo/ModalDemo.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ModalDeprecatedDemo/ModalDeprecatedDemo.tsx

Walkthrough

All Modal example and demo files replace the WarningTriangleIcon import and render call with RhUiWarningIcon. The change affects two .md documentation files and four .tsx component files across both the current and deprecated Modal examples, as well as the integration demo app.

Changes

Modal Warning Icon Replacement

Layer / File(s) Summary
Icon swap across all Modal examples and demos
packages/react-core/src/components/Modal/examples/Modal.md, packages/react-core/src/components/Modal/examples/ModalCustomHeader.tsx, packages/react-core/src/deprecated/components/Modal/examples/Modal.md, packages/react-core/src/deprecated/components/Modal/examples/ModalCustomHeaderFooter.tsx, packages/react-integration/demo-app-ts/src/components/demos/ModalDemo/ModalDemo.tsx, packages/react-integration/demo-app-ts/src/components/demos/ModalDeprecatedDemo/ModalDeprecatedDemo.tsx
Replaces WarningTriangleIcon import and render usage with RhUiWarningIcon in all Modal example docs, example components, and integration demo components for both current and deprecated Modal variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • nicolethoen
  • thatblindgeye
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely describes the main change: replacing WarningTriangleIcon with RhUiWarningIcon across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

…gIcon

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-warning-triangle-icon-with-rh-ui-warning branch from 4191abf to f892ec3 Compare June 23, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants